Discussion:
Product build always modify config.ini
(too old to reply)
Sebastien Gandon
2014-09-03 15:31:28 UTC
Permalink
Hello,
We are migrating our PDE build to tycho using .product definition for our product generation.
In our product we specify a config.ini file to be used instead of it getting automatically generated.
Nevertheless our config.ini gets modified by the list of bundles to be launched.

Is there a ways to prevent this as we have our own rcp launcher based on a license file and therefore do not want the property « osgi.bundles » to be modified ?

Of course we can use the "maven-resources-plugin » at the packaging phase to overwrite the file but is there a cleanest way ?
Thanks.

SeB.

Sébastien Gandon
Eclipse Software Architect
Email : ***@talend.com<mailto:***@talend.com> | Skype : sebastien.gandon.talend.com
Talend SA | 9, rue Pagès - 92150 Suresnes - France | +33 1 46 25 06 00 | www.talend.com<http://www.talend.com>
Global Leader in Open Source Integration

[cid:B72C902E-0157-4059-80C5-8C498696043B]<http://www.talend.com>
Jeff MAURY
2014-09-04 08:38:52 UTC
Permalink
When you generate the product from within Eclipse, do you observe the same
behaviour ?

Jeff
Post by Sebastien Gandon
Hello,
We are migrating our PDE build to tycho using .product definition for our
product generation.
In our product we specify a config.ini file to be used instead of it
getting automatically generated.
Nevertheless our config.ini gets modified by the list of bundles to be launched.
Is there a ways to prevent this as we have our own rcp launcher based on
a license file and therefore do not want the property « osgi.bundles » to
be modified ?
Of course we can use the "maven-resources-plugin » at the packaging
phase to overwrite the file but is there a cleanest way ?
Thanks.
SeB.
*Sébastien Gandon*
*Eclipse Software Architect *
*Talend* *SA *| 9, rue PagÚs - 92150 Suresnes - France | +33 1 46 25 06 00
| www.talend.com
*Global Leader in Open Source Integration*
<http://www.talend.com>
_______________________________________________
tycho-user mailing list
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/tycho-user
--
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury
Sebastien Gandon
2014-09-04 12:41:32 UTC
Permalink
Hi Jeff,
Jeff MAURY
2014-09-04 13:05:49 UTC
Permalink
I'm not sure I understand correctly. If you run from Eclipse, your product
config.ini is correct ?
This may be because Tycho cannot resolve the reference to the external
config.ini.
Can you see in the .product file to see how it is specified ?

Jeff
Post by Sebastien Gandon
Hi Jeff,
Sebastien Gandon
2014-09-04 13:11:35 UTC
Permalink
Nope, Tycho finds my config.ini fine because it is the right file that end-up in the final product except that it modifies the « osgi.bundles » property where it should not.
So to be clear, using eclipse export my config.ini is used and not modified, using tycho it is used too but some properties are modified without my consent.

SeB.

De : Jeff MAURY <***@jeffmaury.com<mailto:***@jeffmaury.com>>
Répondre à : Tycho user list <tycho-***@eclipse.org<mailto:tycho-***@eclipse.org>>
Date : jeudi 4 septembre 2014 15:05
À : Tycho user list <tycho-***@eclipse.org<mailto:tycho-***@eclipse.org>>
Objet : Re: [tycho-user] Product build always modify config.ini

I'm not sure I understand correctly. If you run from Eclipse, your product config.ini is correct ?
This may be because Tycho cannot resolve the reference to the external config.ini.
Can you see in the .product file to see how it is specified ?

Jeff


On Thu, Sep 4, 2014 at 2:41 PM, Sebastien Gandon <***@talend.com<mailto:***@talend.com>> wrote:
Hi Jeff,
Jeff MAURY
2014-09-04 13:35:39 UTC
Permalink
I've look at the Tycho code (
https://github.com/eclipse/tycho/blob/master/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/packaging/ProductExportMojo.java)
and see that the config.ini is always generated. Are you sure that Tycho
loads your external file because the way it is store in the .product file
is through a workspace reference (/project/folder1/folder2/config.ini)
which cannot be resolved by Tycho

Jeff
Post by Sebastien Gandon
Nope, Tycho finds my config.ini fine because it is the right file that
end-up in the final product except that it modifies the « osgi.bundles »
property where it should not.
So to be clear, using eclipse export my config.ini is used and not
modified, using tycho it is used too but some properties are modified
without my consent.
SeB.
Date : jeudi 4 septembre 2014 15:05
Objet : Re: [tycho-user] Product build always modify config.ini
I'm not sure I understand correctly. If you run from Eclipse, your
product config.ini is correct ?
This may be because Tycho cannot resolve the reference to the external config.ini.
Can you see in the .product file to see how it is specified ?
Jeff
Post by Sebastien Gandon
Hi Jeff,
Sebastien Gandon
2014-09-04 14:20:06 UTC
Permalink
Yep, I am sure, I even see our config.ini copied in the target/products/<our product id>/config.ini without any modification;
And then the final target/products/<our product id>/win32/win32/x86_64/configuration/config.ini with the bundles injected with a new osgi.bundles key.

But you are right, we had to change the reference to the config.ini file and remove the workspace reference, the config file is located next to the .product and we just used the file name.

SeB.
De : Jeff MAURY <***@jeffmaury.com<mailto:***@jeffmaury.com>>
Répondre à : Tycho user list <tycho-***@eclipse.org<mailto:tycho-***@eclipse.org>>
Date : jeudi 4 septembre 2014 15:35
À : Tycho user list <tycho-***@eclipse.org<mailto:tycho-***@eclipse.org>>
Objet : Re: [tycho-user] Product build always modify config.ini

I've look at the Tycho code (https://github.com/eclipse/tycho/blob/master/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/packaging/ProductExportMojo.java) and see that the config.ini is always generated. Are you sure that Tycho loads your external file because the way it is store in the .product file is through a workspace reference (/project/folder1/folder2/config.ini) which cannot be resolved by Tycho

Jeff


On Thu, Sep 4, 2014 at 3:11 PM, Sebastien Gandon <***@talend.com<mailto:***@talend.com>> wrote:
Nope, Tycho finds my config.ini fine because it is the right file that end-up in the final product except that it modifies the « osgi.bundles » property where it should not.
So to be clear, using eclipse export my config.ini is used and not modified, using tycho it is used too but some properties are modified without my consent.

SeB.

De : Jeff MAURY <***@jeffmaury.com<mailto:***@jeffmaury.com>>
Répondre à : Tycho user list <tycho-***@eclipse.org<mailto:tycho-***@eclipse.org>>
Date : jeudi 4 septembre 2014 15:05

À : Tycho user list <tycho-***@eclipse.org<mailto:tycho-***@eclipse.org>>
Objet : Re: [tycho-user] Product build always modify config.ini

I'm not sure I understand correctly. If you run from Eclipse, your product config.ini is correct ?
This may be because Tycho cannot resolve the reference to the external config.ini.
Can you see in the .product file to see how it is specified ?

Jeff


On Thu, Sep 4, 2014 at 2:41 PM, Sebastien Gandon <***@talend.com<mailto:***@talend.com>> wrote:
Hi Jeff,

Loading...